Skip to content

chore: validate each entry in serialization instead of whole object#456

Merged
Brentlok merged 1 commit into
mainfrom
serialization-validation-improvement
Mar 16, 2026
Merged

chore: validate each entry in serialization instead of whole object#456
Brentlok merged 1 commit into
mainfrom
serialization-validation-improvement

Conversation

@Brentlok

@Brentlok Brentlok commented Mar 16, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Thanks mertcanekiz for inspiration in #448

Summary by CodeRabbit

  • Chores

    • Updated dev dependencies: dprint (0.53.0) and turbo (2.8.17)
    • Updated TypeScript formatting tool plugin for improved compatibility

  • Improvements

    • Enhanced validation logic with filtering and error logging for better reliability

@Brentlok Brentlok merged commit 70d8a86 into main Mar 16, 2026
1 check passed
@Brentlok Brentlok deleted the serialization-validation-improvement branch March 16, 2026 13:54
@Brentlok Brentlok mentioned this pull request Mar 16, 2026
Closed
4 tasks
@coderabbitai

coderabbitai Bot commented Mar 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9f7d2dd2-b744-4e84-915f-ddfc10d821e4

📥 Commits

Reviewing files that changed from the base of the PR and between 34693ea and a463325.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • apps/vite-example/package.json
  • dprint.json
  • package.json
  • packages/uniwind/package.json
  • packages/uniwind/src/metro/utils/serialize.ts
📝 Walkthrough

Walkthrough

This PR consolidates dependency management and updates build tooling. Vite is migrated to catalog-based resolution in multiple packages, tool versions are bumped (dprint, turbo, TypeScript plugin), and validation logic in serialize.ts is refactored from global to per-entry validation with filtering.

Changes

Cohort / File(s) Summary
Catalog-based Vite Resolution
apps/vite-example/package.json, packages/uniwind/package.json		 Migrated vite from fixed version constraints to catalog-based resolution ("catalog:").
Dependency Catalog Updates
package.json		 Added vite 7.2.6 to catalog dependencies; bumped dprint (0.52.0 → 0.53.0) and turbo (2.8.16 → 2.8.17) in devDependencies.
Build Tool Version
dprint.json		 Updated TypeScript plugin binary from typescript-0.88.7.wasm to typescript-0.95.15.wasm.
Validation Logic Refactor
packages/uniwind/src/metro/utils/serialize.ts		 Replaced global object validation with per-entry validation; invalid entries are filtered out and logged during serialization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Dependencies now dance through the catalog's hall,
Vite's constraints released, unified for all,
Tools ascend with version bumps so fine,
Validation now gentle, entry by line,
Hopping forward with changes both small and kind! 🌟

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch serialization-validation-improvement
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use your project's `biome` configuration to improve the quality of JS/TS/CSS/JSON code reviews.

Add a configuration file to your project to customize how CodeRabbit runs biome.

@github-actions

github-actions Bot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

🚀 This pull request is included in v1.6.0. See Release v1.6.0 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Brentlok